Script templates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed import to read in the checklist
script modified to removed unneeded scripts
m-misiura
reviewed
Feb 9, 2023
Comment on lines
33
to
35
| ├─ model/ | ||
| ├─ raw/ | ||
| ├─ wrangle/ |
There was a problem hiding this comment.
would it be useful to re-order these in terms of the actual order of the workflow i.e. raw -> wrangle -> model ?
m-misiura
reviewed
Feb 9, 2023
| @@ -9,7 +9,7 @@ pip install cookiecutter | |||
| cookiecutter https://github.com/NICD-UK/project-template | |||
| ``` | |||
|
|
|||
| You will be prompted for nine inputs: | |||
| You will be prompted for eleven inputs: | |||
There was a problem hiding this comment.
consider changing "eleven" to "the following"
m-misiura
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Reviewed all 16 files:
pyprojrootappears to be the cleanest solution to the problem of specifying paths without../- the flow from
raw->clean->wrangleappears to be fine for both Python and R files - is the file
{{cookiecutter.project_directory_name}}/notebooks/.gitkeepneeded ? it's an empty file - there are some very minor comments on the README.md
Overall, great job !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Python and R template to the project template. You can now select the language of choice.